Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2018, add optional 2nd arg, use spans and quote, add wrap macro for stable rust #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheButlah
Copy link

@TheButlah TheButlah commented Sep 16, 2022

This PR seeks to improve this crate with the following:

  • Bumps edition to 2018 to use more modern macro import style
  • Uses spans to improve error messages
  • Uses the quote! crate instead of manually constructing token streams
  • Adds an optional 2nd argument for dynpath macro that gives the ability to manually change the suffix
  • Adds a wrap macro that lets the dynpath macro work on stable rust
  • Improves documentation of the macros
  • Doctests no longer fail

Closes #1

@TheButlah
Copy link
Author

Pinging reviewer 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-inline modules are not stable
1 participant