Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the options "once" and "strict" to the actions GrowTo* and MoveTo* #8

Open
wants to merge 19 commits into
base: work
Choose a base branch
from

Conversation

deters
Copy link

@deters deters commented Sep 3, 2013

Just noticed... github updates automatically my pull request to the latest revision...

I'm proposing this 2 new options:

  1. "once": will restrict GrowTo_/MoveTo_ to the nearest blocking edges.

  2. "strict": forces GrowTo* actions to do strictly what they name says: grow. So, this option will prevent GrowTo from shrinking.

The name "strict" is just a suggestion, I tryed to think in a generic name who could be applied to any other methods who have "controversal" behaviours. The "strict" was implemented only on GrowTo* actions.

More info & Usage:
https://bugzilla.icculus.org/show_bug.cgi?id=3356#c38

danakj and others added 8 commits September 1, 2013 15:17
Currently the code rolls its own binary search, but now that we have
a well-tested binary search implementation in obt/ we can make use
of that.
This extend the client_find_resize_directional() method to support
two growing modes, and return a bool for whether it was able to grow/shrink.

The client_find_resize_directional() method now takes an enum instead
of a bool, with two growing modes. The old mode which always tries to
grow, the a new mode that will only grow if the client's edge is not
already at a grow stopping point (ie against the edge of another window).
This change points out how useless the return value from client_find_resize_directional()
was, so it also removes that.

When all edges are blocked, the FillToEdge action will try to grow all four edges agin
without blocking any of them on their current edge. This more closely matches the
behaviour of the GrowToEdge action.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants