Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some typos in readme #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: some typos in readme #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ you can view the whole content.
## Prerequisites
You'll need to have checked out the node.js source.

### Compiling Node.js with debug enbled:
### Compiling Node.js with debug enabled:

$ ./configure --debug
$ make -C out BUILDTYPE=Debug
Expand All @@ -17,16 +17,16 @@ After compiling (with debugging enabled) start node using lldb:
$ cd node/out/Debug
$ lldb ./node

Node uses Generate Your Projects (gyp) for which I was not familiar with so there is a
Node uses Generate Your Projects (gyp) for which I was not familiar with so there is an
example project in [gyp](./gyp) to look into it.

### Running the Node.js tests

$ make -j8 test

## Notes
The rest of this page contains notes gathred while setting through the code base:
(These are more sections than listed here but they might be hard to follow)
The rest of this page contains notes gathered while setting through the code base:
(These are more sections than listed here, but they might be hard to follow)

1. [Background](#background)
2. [Start up](#starting-node)
Expand Down Expand Up @@ -461,7 +461,7 @@ So ExecuteBootstrapper will call the function in `internal/bootstrap/loaders.js`
```console
(lldb) jlh bootstrapper
```
I'm not showing the output as it is a little long but you can see the contents of loaders.js.
I'm not showing the output as it is a little long, but you can see the contents of loaders.js.
We can see the arguments that the function takes:
```javascript
- source code: (process, getBinding, getLinkedBinding, getInternalBinding) {
Expand Down Expand Up @@ -4200,7 +4200,7 @@ Also, notice that we are setting the processImmediate instance as a member of th
env->as_external()).FromJust());
```
So when we do `process_.immediateCallback` `NeedImmediateCallbackSetter` will be invoked.
Looking closer at this function and comparing it with a [libuv check example](https://github.com/danbev/learning-libuv/blob/master/check.c) we should see some similarties.
Looking closer at this function and comparing it with a [libuv check example](https://github.com/danbev/learning-libuv/blob/master/check.c) we should see some similarities.

```c++
uv_check_t* immediate_check_handle = env->immediate_check_handle();
Expand Down