Skip to content

Commit

Permalink
test: enable node-module-version/test.js with debug
Browse files Browse the repository at this point in the history
Commit fdca79f ("test: enable addons
test to pass with debug build") enabled the addons tests to pass when
the build type is of type debug (configure --debug).

test/addons/node-module-version/test.js was recently added and expects
the the build type to be of type Release (like most of the others until
recently). This commit allows this test to pass when the build type if
of type debug.

PR-URL: nodejs#9093
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
danbev committed Oct 17, 2016
1 parent 2ebd445 commit 9bb250b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/addons/node-module-version/test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
'use strict';

require('../../common');
const common = require('../../common');
const assert = require('assert');

const re = new RegExp(
'was compiled against a different Node.js version using\n' +
'NODE_MODULE_VERSION 42. This version of Node.js requires\n' +
`NODE_MODULE_VERSION ${process.versions.modules}.`);

assert.throws(() => require('./build/Release/binding'), re);
assert.throws(() => require(`./build/${common.buildType}/binding`), re);

0 comments on commit 9bb250b

Please sign in to comment.