Fix #101, make read_tags skip extra \0 bytes #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some WAV files contain extra consecutive \0 bytes in RIFF INFO section, which causes issues if not skipped over properly. See dancasimiro#101 for details
CMGeldenhuys
added a commit
to CMGeldenhuys/WAV.jl
that referenced
this pull request
Jun 21, 2021
Some WAVE files are not just padded with \0 bytes (null terminators) but arbitrary bytes. This causes the bug outlined in dancasimiro#101 & dancasimiro#102. Instead of looking for consecutive \0 bytes read size from CHUNK and ignore remainder of unused data. See dancasimiro#101, dancasimiro#102
CMGeldenhuys
added a commit
to CMGeldenhuys/WAV.jl
that referenced
this pull request
Jun 21, 2021
Some WAVE files are not just padded with \0 bytes (null terminators) but arbitrary bytes. This causes the bug outlined in dancasimiro#101 & dancasimiro#102. Instead of looking for consecutive \0 bytes read size from CHUNK and ignore remainder of unused data. See dancasimiro#101, dancasimiro#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some WAV files contain extra consecutive \0 bytes in RIFF INFO section, which causes issues if not skipped over properly. See #101 for details