Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wavplay on linux, and maybe OSX #85

Merged
merged 1 commit into from
Jul 11, 2020
Merged

Fix wavplay on linux, and maybe OSX #85

merged 1 commit into from
Jul 11, 2020

Conversation

contradict
Copy link
Contributor

This change fixes the wavplay method on Linux, I don't have an OS X machine to test but it might work there too.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 67.245% when pulling 4e08611 on contradict:update-wavplay into b6a1b7f on dancasimiro:master.

@dancasimiro
Copy link
Owner

Are the OS checks strictly required? I wonder if it would be more flexible to simply check for presence of the libraries. That might make it work on other operating systems, such as windows.

@contradict
Copy link
Contributor Author

I was following the advice here for dealing with OS differences.

It looks like there is a preview of PulseAudio for windows and maybe even a way to get it working on OSX, so this might work. I don't have a Windows machine to test with either, so I have no way to test this approach.

If it did work, it seems that PulseAudio is not the first choice for audio on either of these platforms, so testing for the libraries would still need an OS-dependent search order. I think splitting by OS first and then searching for a library that works is a more practical strategy than looking for a library that works everywhere. This also splits the maintenance to people who are proficient with each platform (or even have an example to test).

@dancasimiro
Copy link
Owner

I think that the library checks are sufficient and that the OS checks are superfluous. However, this is a step in the right direction and I will merge as is.

@dancasimiro dancasimiro merged commit 701f960 into dancasimiro:master Jul 11, 2020
dancasimiro added a commit that referenced this pull request Jul 26, 2020
Update the version number on Project.toml in preparation for releasing v1.0.4. This release fixes wavplay for modern Julia (#85), as well as integrates documentation into the julia help system (#86).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants