add wavplay() support for Windows, minor doc tweaks #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this package gets precompiled and cached before the user has installed a pre-requisite shared library, then installing said library will not fix the problem if the check for the presence happened at compile time. Likewise, if PackageCompiler.jl is used to compile an app on another machine, then absence of a required shared library at compile time there cannot be rectified later by a user who downloaded a pre-compiled app containing this package. Dropping the compile-time check for the presence of the required shared libraries fixes this. The exception raised by ccall() if the required library is missing is anyway more informative than the warning messages removed here. https://julialang.github.io/PackageCompiler.jl/dev/devdocs/relocatable_part_3/
dancasimiro
approved these changes
Aug 8, 2020
|
Thank you for this contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.