Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fillers: convert remaining fillers to pytest format #14

Conversation

danceratopz
Copy link
Owner

Convert the remaining following fillers to pytest format:

  • withdrawals/withdrawals.py
  • vm/dup.py
  • security/selfdestruct_balance_bug.py

Experimented with a couple of new patterns for test/fixture code organization in withdrawals, in particular in TestZeroValue:

  • Use an enum class to define test case names.
  • Combine test case parameters in one fixture test_case_parameters that returns a dict with the aim of keeping the definition of parameters that make up a test case together.

fillers/withdrawals/withdrawals.py Outdated Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Show resolved Hide resolved
fillers/vm/dup.py Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, thanks! :)

fillers/vm/dup.py Outdated Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Show resolved Hide resolved
fillers/vm/dup.py Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Show resolved Hide resolved
fillers/withdrawals/withdrawals.py Outdated Show resolved Hide resolved
@danceratopz danceratopz force-pushed the feature/use-pytest-to-collect-and-hydrate-test-fillers-v2 branch from 536a25d to 0c8ee04 Compare May 31, 2023 11:55
@danceratopz danceratopz force-pushed the fillers/convert-remaining-fillers-to-pytest-format branch from b548105 to 197a70a Compare May 31, 2023 13:15
@danceratopz danceratopz merged commit 301cbcd into feature/use-pytest-to-collect-and-hydrate-test-fillers-v2 Jun 1, 2023
@danceratopz danceratopz deleted the fillers/convert-remaining-fillers-to-pytest-format branch June 23, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants