forked from ethereum/execution-spec-tests
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fillers: convert remaining fillers to pytest format #14
Merged
danceratopz
merged 10 commits into
feature/use-pytest-to-collect-and-hydrate-test-fillers-v2
from
fillers/convert-remaining-fillers-to-pytest-format
Jun 1, 2023
Merged
fillers: convert remaining fillers to pytest format #14
danceratopz
merged 10 commits into
feature/use-pytest-to-collect-and-hydrate-test-fillers-v2
from
fillers/convert-remaining-fillers-to-pytest-format
Jun 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
danceratopz
commented
May 18, 2023
marioevz
reviewed
May 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, thanks! :)
danceratopz
force-pushed
the
feature/use-pytest-to-collect-and-hydrate-test-fillers-v2
branch
from
May 31, 2023 11:55
536a25d
to
0c8ee04
Compare
Co-authored-by: Dan <danceratopz@gmail.com>
danceratopz
force-pushed
the
fillers/convert-remaining-fillers-to-pytest-format
branch
from
May 31, 2023 13:15
b548105
to
197a70a
Compare
danceratopz
merged commit Jun 1, 2023
301cbcd
into
feature/use-pytest-to-collect-and-hydrate-test-fillers-v2
danceratopz
deleted the
fillers/convert-remaining-fillers-to-pytest-format
branch
June 23, 2023 06:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the remaining following fillers to pytest format:
Experimented with a couple of new patterns for test/fixture code organization in withdrawals, in particular in
TestZeroValue
:test_case_parameters
that returns a dict with the aim of keeping the definition of parameters that make up a test case together.