-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Incompatible with binary caches from latest bat #895
Comments
Thanks! So if I'm understanding correctly, the problem here affects people (like me, and you) who have custom themes/syntaxes in a local cache which we are sharing with bat. Currently delta has copied/vendored code handling binary assets from bat . But I wonder if we can make use of some of the bat-as-a-library features mentioned in the release notes: https://github.com/sharkdp/bat/releases/tag/v0.19.0 |
The immediate fix here would be to use an older version of bat to create the custom theme for delta. The real fix is this unreleased delta PR #903 and the accompanying bat PR sharkdp/bat#2030 which would need to be released first. |
...in April, they say. I'll keep my |
Right. In the interim we could, in principle, update the binary assets in delta "manually" and apply any changes to our vendored bat code that are necessary, and release delta like that. Perhaps there are no code changes required -- it's just that when this issue was opened I decided to look into using bat as a library properly rather than doing the delta binary assets upgrade that I usually do at delta releases. It is time for a delta release -- I was trying to get #939 in. |
No worries. It's not your fault. In any case, it's no great hardship. I use |
Use assets API from bat library Fixes #895 Ref sharkdp/bat#2026 Thanks @Enselic
This is fixed in the latest delta version (the bat PR was released). |
bat recently released a new version v0.19.0, after updating I got the following error when using bat:
After rebuilding the cache, delta started falling back to default syntax theme. Turns out delta needs to release a compatible version as well?
The text was updated successfully, but these errors were encountered: