Allow multiple hyperlinks per line #1909
Conversation
src/features/hyperlinks.rs
Outdated
| let formatted_commit = | ||
| format_osc8_hyperlink(&commit_link_format.replace("{commit}", commit), commit); |
There was a problem hiding this comment.
What about filtering out pure numbers here again, as mentioned in the issue?
There was a problem hiding this comment.
Yes, why not. The posterior probability of such a string being a number is going to be considerably higher than that of it being a commit. Multiplied by the probability that someone happened to care about the link to their improbably-digit-rich commit...
src/features/hyperlinks.rs
Outdated
| commit = commit, | ||
| osc = "\x1b]", | ||
| st = "\x1b\\" | ||
| ); |
There was a problem hiding this comment.
Is there a reason that we can't use format_osc8_hyperlink here also? And beyond that, The two branches of this function are quite substantial and look very similar -- did you decide it wasn't attractive to unite them?
There was a problem hiding this comment.
Right, just didn't want think about how to nicely factor that out :) - What about this HyperlinkCommits helper now?
src/features/hyperlinks.rs
Outdated
| format!( | ||
| "{osc}8;;{url}{st}{commit}{osc}8;;{st}", | ||
| url = repo.format_commit_url(commit), | ||
| commit = commit, | ||
| osc = "\x1b]", | ||
| st = "\x1b\\" |
There was a problem hiding this comment.
Can be replaced with format_osc8_hyperlink(), right?
There was a problem hiding this comment.
Yes I believe so. I'm not sure why the previous code wasn't already using that. Hopefully just a historical accident rather than a Chesterton's fence.
There was a problem hiding this comment.
Done (tests agree)!
Previously only the last commit was linked. Do not link numbers (technically also commits), and stop after finding 12 commits on a line.
Previously only the last commit was linked
Do not link numbers (technically also commits), and stop after
finding 12 commits on a line.
Fixes #1907
I'd want to enhance all the current assertions with pretty_assertions, that is no work compared to using insta.