oss-1840 #1
Open
oss-1840 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
force-pushed
the
oss-1840
branch
2 times, most recently
from
78d02df to
c70e42a
Compare
* Update protos * Set new server / SDK metadata to their zero values
We're using APIs that are only available in v5.5 (e.g. .insert() is used in core/src/worker/activities.rs). In practice, when compiling sdk-core alone, v5.5 was already what was being picked up and there was no problem. However, when sdk-core is compiled as a crate in the sdk-typescript core-bridge project, v5.4 is getting picked up, with the result that sdk-core fails to build in that context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.