Disable GUI "Unembargo" button if there are active uploads #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @jjnesbitt |
jjnesbitt
force-pushed
the
disable-unembargo-on-active-uploads
branch
from
33f167c
to
7df964a
Compare
waxlamp
reviewed
Aug 28, 2024
mvandenburgh
approved these changes
Aug 29, 2024
That would address the newly filed #2021. |
jjnesbitt
force-pushed
the
disable-unembargo-on-active-uploads
branch
from
7df964a
to
1368f37
Compare
jjnesbitt
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there's a quirk of the GUI where you're allowed to hit the "Unembargo" button, but which produces an error every time, without any progression. This is due to there being active uploads in the dandiset, which prohibits unembargo.
This PR prevents taking such an action in the GUI, disabling the button and giving the reason. I'd like to follow up this PR with a more robust improvement to uploads, adding the ability to "clear" any in progress uploads. Currently this isn't possible, leading to a very awkward situation.