-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Built-in BIDS support for dandi upload
#1011
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
+ Coverage 87.65% 88.41% +0.75%
==========================================
Files 65 72 +7
Lines 8189 9233 +1044
==========================================
+ Hits 7178 8163 +985
- Misses 1011 1070 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This pull request introduces 1 alert when merging 46bcdb1 into 14030cb - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging d508c7b into 0016e60 - view on LGTM.com new alerts:
|
@jwodder putting it on draft for now to not waste your time. Need to test some things re typing first. |
@jwodder ok, figured out the typing issues :) Everything else you mentioned should already be in. |
@yarikoptic @jwodder should be done, unless you notice some additional issues. Not sure what's going on with the documentation, but probably unrelated. |
@jwodder @yarikoptic could I get another review on this, or otherwise could this be merged? |
I will check it out tomorrow morning. Thanks! |
I have reservations since testing is quite "limited" as for number of use cases code tries to cover with the discovery of bids datasets... also tried on some dummy ds210 from bids-examples, it still required explicit paths and --allow-any-path... will file separate issues for that. For now -- let's just proceed. |
🚀 PR was released in |
@yarikoptic @satra still as draft, some things might still be weird, and need to come up with tests.
Eventually it will look like this (contains both normal and validation ignore usage), and if the number of invalid files is not 18k, the output also does not need to contain 18k lines :)
https://ppb.chymera.eu/1c32cb