Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy dependency issue in tests #356

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix numpy dependency issue in tests #356

merged 2 commits into from
Feb 1, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Feb 1, 2021

Fixes #352.

Fix inspired by this comment.

Unfortunately, I do not see a way to ensure that users of dandi-cli who do not already have numpy installed do not run into this problem.

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #356 (3ed64f2) into master (9168bfb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   81.92%   81.92%           
=======================================
  Files          55       55           
  Lines        5371     5371           
=======================================
  Hits         4400     4400           
  Misses        971      971           
Flag Coverage Δ
unittests 81.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9168bfb...3ed64f2. Read the comment docs.

@jwodder jwodder changed the title Attempt at fixing numpy dependency hell Fix numpy dependency issue in tests Feb 1, 2021
@jwodder jwodder added the internal Changes only affect the internal API label Feb 1, 2021
@jwodder jwodder marked this pull request as ready for review February 1, 2021 20:02
@yarikoptic
Copy link
Member

Thank you @jwodder !!!! I expect the issue to be properly resolved "upstream" and workaround would let us keep going, thus merging

@yarikoptic yarikoptic merged commit 59fc406 into master Feb 1, 2021
@yarikoptic yarikoptic deleted the gh-352 branch February 1, 2021 22:58
@jwodder
Copy link
Member Author

jwodder commented Feb 2, 2021

@yarikoptic I'm not sure if this will be fixed upstream, as it only affects h5py 2.x, and the project is already on to 3.1.

@jwodder jwodder added tests Add or improve existing tests and removed internal Changes only affect the internal API labels Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOI: 3.9 with h5py 2.10.0 started to fail to import
2 participants