Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State explicitly that our current maximal length of the path in dandiset must no exceed 512 #124

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

yarikoptic
Copy link
Member

ATM, if my check is right -- maximal length we can encounter is only 192, so we are quite ok

dandi@drogon:/mnt/backup/dandi/dandisets$ pwd
/mnt/backup/dandi/dandisets

dandi@drogon:/mnt/backup/dandi/dandisets$ declare m=0;for ds in 00*; do git -C $ds ls-tree -r --name-only HEAD; done | awk '{ if (length($0) > max) max = length($0) } END { print max }'
192

When user manages to get over -- server 500s. Filed

…set must not exceed 512

ATM, if my check is right -- maximal length we can encounter is only 192, so we
are quite ok

	dandi@drogon:/mnt/backup/dandi/dandisets$ pwd
	/mnt/backup/dandi/dandisets

	dandi@drogon:/mnt/backup/dandi/dandisets$ declare m=0;for ds in 00*; do git -C $ds ls-tree -r --name-only HEAD; done | awk '{ if (length($0) > max) max = length($0) } END { print max }'
	192

When user manages to get over -- server 500s. Filed
dandi/dandi-archive#1889
@yarikoptic yarikoptic requested a review from satra March 7, 2024 01:43
@satra
Copy link
Member

satra commented Mar 7, 2024

we don't put dandi nwb inspector or schema constraints in the policy document. is this really something for a policy change? also if this is a policy change, the policy version should be incremented.

i would say this is out of scope for this policy document.

Copy link
Member

@satra satra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@yarikoptic
Copy link
Member Author

It has nothing to do with nwb and inspectors. See the issue I linked in the archive - it is our current coded in technical limitation similarly to max file size on s3.

@yarikoptic
Copy link
Member Author

per discussion on slack -- moved both into another document from Policy and boosted policy version.

@yarikoptic yarikoptic requested a review from satra March 7, 2024 18:21
@yarikoptic yarikoptic merged commit abbe4ca into master Mar 7, 2024
1 check passed
@kabilar kabilar deleted the max-path branch March 29, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants