Serve Zarrs view via manifests at /zarrs/
#52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failure on "nightly" is due to zowens/crc32c#51 and doesn't matter for our purposes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage ? 35.05%
=======================================
Files ? 23
Lines ? 3323
Branches ? 0
=======================================
Hits ? 1165
Misses ? 2158
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
Great -- thank you! Let's try in production! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43.
Notes on the implementation:
The deserialized JSON manifests are cached by the server. The cache stores 16 manifests, with the least-frequently used being evicted when the size is exceeded.
Paths under https://datasets.datalad.org/dandi/zarr-manifests/zarr-manifests-v2-sorted/ are assumed to take only the following forms:
{any}/{any}/{any}/{any}/{any}/{any}/{any}/{any}/{any}/{any-non-period}.json— Manifests (where the last{any}is the Zarr ID), served bydandidavas directories without the.jsonextensionPaths that do not have one of the above forms may be listed by
dandidavunder certain circumstances but will result in a 404 upon access.