Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make authenticateUser function throwing #27

Merged
merged 2 commits into from
May 22, 2022

Conversation

Tunous
Copy link
Contributor

@Tunous Tunous commented May 22, 2022

This pull request adds a throwing version of authenticateUser function.

By making this function throwing we remove from the user the need to handle third (most likely never happening) state where both user and error are nil.

@daneden daneden merged commit 9f50f1f into daneden:main May 22, 2022
@daneden
Copy link
Owner

daneden commented May 22, 2022

Nice catch! Thanks for contributing @Tunous!

@Tunous Tunous deleted the throwing-authenticateUser branch May 22, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants