#364 Proofs for several footnote tests.

danfickle · Sep 5, 2021 · 055c0b3 · 055c0b3
1 parent a815eb1
commit 055c0b3
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 11 deletions.
diff --git a/openhtmltopdf-examples/src/main/resources/visualtest/expected/footnote/issue-364-floats.pdf b/openhtmltopdf-examples/src/main/resources/visualtest/expected/footnote/issue-364-floats.pdf
diff --git a/...f-examples/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-blocks.pdf b/...f-examples/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-blocks.pdf
diff --git a/...s/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-paginated-table.pdf b/...s/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-paginated-table.pdf
diff --git a/...xamples/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-too-large.pdf b/...xamples/src/main/resources/visualtest/expected/footnote/issue-364-footnotes-too-large.pdf
diff --git a/openhtmltopdf-examples/src/main/resources/visualtest/expected/footnote/issue-364-images.pdf b/openhtmltopdf-examples/src/main/resources/visualtest/expected/footnote/issue-364-images.pdf
diff --git a/openhtmltopdf-examples/src/main/resources/visualtest/html/footnote/issue-364-floats.html b/openhtmltopdf-examples/src/main/resources/visualtest/html/footnote/issue-364-floats.html
@@ -41,7 +41,7 @@
 </style>
 </head>
 <body>
-<p style="margin-top: 0;">
+<p style="margin: 0;">
  This text needs some footnotes. 
  <div id="1" class="footnote">
  <div style="background: blue; width: 40%; float: left;">Floated 1</div>
@@ -55,7 +55,7 @@
  </span>
 </p>
 
-<p style="page-break-before: always;">
+<p style="page-break-before: always; margin: 0;">
  Footnote numbers.
  <div style="float: right; background: red;">Floated 4</div>
  <div id="3" class="footnote">

diff --git a/...opdf-examples/src/main/resources/visualtest/html/footnote/issue-364-footnotes-blocks.html b/...opdf-examples/src/main/resources/visualtest/html/footnote/issue-364-footnotes-blocks.html
@@ -61,7 +61,7 @@
  Another paragraph!
  </p>
  </div>
- <div class="footnote" style="background: pink;">
+ <div class="footnote">
  This however is a purely inline footnote.
  </div>
 

diff --git a/openhtmltopdf-examples/src/main/resources/visualtest/html/footnote/issue-364-images.html b/openhtmltopdf-examples/src/main/resources/visualtest/html/footnote/issue-364-images.html
@@ -46,7 +46,7 @@
 </style>
 </head>
 <body>
-<p style="margin-top: 0;">
+<p style="margin: 0;">
  This text needs some footnotes. 
  <div id="1" class="footnote">
  This is a footnote.
@@ -59,7 +59,7 @@
  </span>
 </p>
 
-<p style="page-break-before: always;">
+<p style="page-break-before: always; margin: 0;">
  Footnote numbers.
  <div id="3" class="footnote">
  Just to be silly this is a really long footnote that will need wrapping and such.

diff --git a/...s/src/test/java/com/openhtmltopdf/visualregressiontests/FootnoteVisualRegressionTest.java b/...s/src/test/java/com/openhtmltopdf/visualregressiontests/FootnoteVisualRegressionTest.java
@@ -8,7 +8,6 @@
 import java.io.IOException;
 import org.junit.Before;
 import org.junit.BeforeClass;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 
@@ -61,7 +60,6 @@ public void testIssue364FootnotesMultiPage() throws IOException {
  * do not fit on a single page.
  */
  @Test
- @Ignore
  public void testIssue364FootnotesTooLarge() throws IOException {
  assertTrue(vt.runTest("issue-364-footnotes-too-large"));
  }
@@ -72,7 +70,6 @@ public void testIssue364FootnotesTooLarge() throws IOException {
  * with the footnote area.
  */
  @Test
- @Ignore
  public void testIssue364FootnotesBlocks() throws IOException {
  assertTrue(vt.runTest("issue-364-footnotes-blocks"));
  }
@@ -82,7 +79,6 @@ public void testIssue364FootnotesBlocks() throws IOException {
  * presence of footnotes.
  */
  @Test
- @Ignore
  public void testIssue364FootnotesPaginatedTable() throws IOException {
  assertTrue(vt.runTest("issue-364-footnotes-paginated-table"));
  }
@@ -121,7 +117,6 @@ public void testIssue364PositionedInsideFootnotes() throws IOException {
  * </ul>
  */
  @Test
- @Ignore
  public void testIssue364Floats() throws IOException {
  assertTrue(vt.runTest("issue-364-floats"));
  }
@@ -130,7 +125,6 @@ public void testIssue364Floats() throws IOException {
  * Tests images in footnotes, as footnotes and intersecting with footnotes.
  */
  @Test
- @Ignore
  public void testIssue364Images() throws IOException {
  assertTrue(vt.runTest("issue-364-images"));
  }