-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic visual testing #208
Comments
danfickle
added a commit
that referenced
this issue
Apr 18, 2018
danfickle
added a commit
that referenced
this issue
May 14, 2018
…o they run automatically at ci. Hopefully this works on travis.
danfickle
added a commit
that referenced
this issue
Jun 8, 2018
Also, close PDF docs in tester code.
danfickle
added a commit
that referenced
this issue
Jun 12, 2018
danfickle
added a commit
that referenced
this issue
Jun 17, 2018
It turned out the problem was in the test rather than the main code. I was trying to test the bottom offset but with no static elements in the body the body had a zero height and so a bottom offset was not visible (being above the top page margin). I fix this by using a min-height for the body and now the bottom offset is working perfectly.
danfickle
added a commit
that referenced
this issue
Sep 5, 2018
danfickle
added a commit
that referenced
this issue
Sep 5, 2018
danfickle
added a commit
that referenced
this issue
Sep 6, 2018
Discovered that there is no way to specify that inline-block elements (including img elements by default) can split between pages.
danfickle
added a commit
that referenced
this issue
Sep 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: