Add support for SVG images #23

ngns · 2016-04-22T09:25:13Z

Currently, SVG images are not supported. PDFBox does not "draw" SVGs natively. Best practice is, to use apache batik to transcode SVGs to PDFs and embed these as PDFFormXObject via PDFBox.

_See also _

SVGs via batic in PDFBox: https://www.mail-archive.com/users@pdfbox.apache.org/msg06998.html
Transcoding SVGs with batic: http://stackoverflow.com/questions/6875807/convert-svg-to-pdf

danfickle · 2016-04-25T13:11:37Z

I decided to create our own transcoder rather than the transcoder provided by FOP. This gives the benefits that it can output to Java2D as well as pdf and can use our user agent, font resolver, etc. However, it is a bit more work so I'm still debugging it and will commit something tomorrow for testing.

ngns · 2016-04-29T16:28:10Z

Should we keep the transcoder to use flexible? Batik is very mature, and will likely be quicker to implement for complex SVGs.
If your are going for Java2D target, maybe it could be built upon existing solutions like Flamingo SVG Transcoder (also batik-based)? http://ebourg.github.io/flamingo-svg-transcoder/

This is a very early prototype using Batik to draw inline SVG graphics in a PDF document. Still to do are images and text in the SVG. Also to do is support for Java 2D.

danfickle · 2016-06-11T12:32:57Z

This is a screen shot showing simple SVG graphics in a PDF.

…lso uses the first color in a SVG linear gradient rather than ignoring it.

danfickle · 2016-06-12T08:57:26Z

danfickle · 2016-06-15T12:53:41Z

With commit bb586a9 you can output custom fonts in SVG like this (text color is still wrong and gradients aren't implemented):

<html>
<head>
<meta charset="UTF-8"/>
<style>
@font-face {
  font-family: 'handwriting';
  src: url(JustAnotherHand.ttf);
}
svg {
    display: block;
}
body {
    font-size: 50px;
}
</style>
</head>
<body>
<svg height="130" width="500" xmlns="http://www.w3.org/2000/svg" version="1.1"
  xmlns:xlink="http://www.w3.org/1999/xlink">
  <defs>
    <linearGradient id="grad1" x1="0%" y1="0%" x2="100%" y2="0%">
      <stop offset="0%" style="stop-color:rgb(255,255,0);stop-opacity:1" />
      <stop offset="100%" style="stop-color:rgb(255,0,0);stop-opacity:1" />
    </linearGradient>
  </defs>
  <ellipse cx="100" cy="70" rx="85" ry="55" fill="url(#grad1)" />
  <text fill="#ffffff" font-size="45" font-family="handwriting" x="50" y="86">SVG</text>
</svg>
</body>
</html>

- Correctly deal with width and height of SVG elements. - Add svg as block element to the base stylesheet (only block elements can be replaced). - Import fonts once per document rather than for every SVG element.

…bled due to issues with the transform origin.

… origin. At least when it comes to SVG transforms, we are now matching Chrome.

rototor · 2016-09-27T16:13:51Z

@danfickle I am not sure if the current approach is the right one. Instead of retrofitting a Graphics2D on a OutputDevice it should just be possible to get a Graphics2D to draw on. Like "createGraphics(rectangle)".

This was possible with iText, but is currently not possible with PdfBox. After I finish #38 I will implement such a PdfBoxGraphics2D, as I need that for some reports where we have Java2D drawing code for some diagrams. And I need text support including the ability to render text as vector paths. But if you want to build such a PdfBoxGraphics2D feel free to do so. The PdfBox seems not interested in such a graphics 2d...

danfickle · 2016-09-28T04:49:05Z

@rototor - I think you have a good point. In fact a standalone Graphics2D implementation which output to PDF would be useful for many projects, not just this one.

I found an old attempt and found some of our code is identical. I don't know who copied who. The old attempt would be useful for some of the maths, etc. It is also licensed under the LGPL.

http://gnujpdf.cvs.sourceforge.net/viewvc/gnujpdf/gnujpdf-1.7/src/gnu/jpdf/PDFGraphics.java?revision=1.6&view=markup

brettclark · 2017-01-12T15:51:22Z

Just curious, is any other image format supported by openhtmltopdf right now? For example, I have a PNG which I need to render.

danfickle · 2017-01-14T06:16:11Z

Hi @brettclark
PNG should work fine. Generally, any image format supported by Java's ImageIO should work including PNG, JPEG and GIF.

rototor · 2017-01-30T10:04:32Z

Just for your information: I started a Graphics2D for PDFBox (https://github.com/rototor/pdfbox-graphics2d) but it seems not to be that simple. I choose the Apache 2.0 Licence, cause maybe PDFBox may want to integrate it when its finished.

…This implements the infrastructure, but does not yet use it to render SVGs.

…oning is not right yet.

rototor · 2017-02-02T16:02:50Z

FYI: I've just created a pull request #66 which implements the SVG rendering using my Graphics2D adapter. It just does the placement of the final XForm wrong at the moment.

* #23: Allow drawing on the output device using a Graphics2D. This implements the infrastructure, but does not yet use it to render SVGs. * #23: Use pdfbox-graphics2d to render the SVG. But the positioning is not right yet.

@rototor

…oxGraphics2D by @rototor - Converts XForm object from 72dpi to 96dpi using the XForm output matrix. - Fixes y to take into account the difference between bottom left coordinate system and top left coordinate system. - Apache Batik SVG renderer is still rendering in 96dpi on a 72dpi device so this will form work for the next commit.

…ace.

@rototor

@rototor - The SVG example is now working perfectly including text, sizing and positioning. Custom fonts via the font-face rule are also working.

…This implements the infrastructure, but does not yet use it to render SVGs.

…oning is not right yet.

…itioning is now right, so it is no longer needed.

danfickle · 2017-02-21T05:50:19Z

Thanks to awesome library and work by @rototor SVG support is largely done.
Current known limitations:

Raster image URIs in SVGs (<image> tag) are not going through the URI resolver so only absolute URIs can be used.
External SVG images are not loaded yet.
Security is not yet assured (do scripts run in any circumstances?) so do not use user provided markup for SVGs (or HTML for that matter).

…h Graphics2D

pilami · 2017-03-30T06:21:33Z

Can this be released to maven repo?

danfickle · 2017-04-03T07:27:58Z

@pilami
Hi, RC10 has been released to Maven now.

jmsalcido · 2018-02-23T02:15:03Z

@danfickle this can be closed now?

danfickle self-assigned this Apr 25, 2016

danfickle added a commit that referenced this issue Jun 11, 2016

For #23 - Initial prototype of SVG support in PDFs

467855c

This is a very early prototype using Batik to draw inline SVG graphics in a PDF document. Still to do are images and text in the SVG. Also to do is support for Java 2D.

danfickle added a commit that referenced this issue Jun 12, 2016

For #23 - Fixes null pointer exception stopping output of SVG text. A…

01ea373

…lso uses the first color in a SVG linear gradient rather than ignoring it.

danfickle added a commit that referenced this issue Jun 19, 2016

For #23 - Experimental code for SVG transforms - not working and disa…

b99b747

…bled due to issues with the transform origin.

danfickle added a commit that referenced this issue Jun 22, 2016

For #23 - Finally implements SVG transforms and the correct transform…

99c1a64

… origin. At least when it comes to SVG transforms, we are now matching Chrome.

danfickle added java2d-work-needed pdfbox-work-needed labels Jun 27, 2016

rototor mentioned this issue Sep 27, 2016

Implement CSS3 transform #38

Closed

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 2, 2017

danfickle#23: Allow drawing on the output device using a Graphics2D. …

22f4063

…This implements the infrastructure, but does not yet use it to render SVGs.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 2, 2017

danfickle#23: Use pdfbox-graphics2d to render the SVG. But the positi…

01323ed

…oning is not right yet.

danfickle added a commit that referenced this issue Feb 13, 2017

For #23 - Clean up SVG user agent by using adapter rather than interf…

eaf1129

…ace.

danfickle added a commit that referenced this issue Feb 13, 2017

For #23 - Copy across attributes on the SVG element such as viewBox.

a32edb8

@rototor - The SVG example is now working perfectly including text, sizing and positioning. Custom fonts via the font-face rule are also working.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Allow drawing on the output device using a Graphics2D. …

5635527

…This implements the infrastructure, but does not yet use it to render SVGs.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Use pdfbox-graphics2d to render the SVG. But the positi…

ca0853b

…oning is not right yet.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Remove the debug rectangle from the svg output. The pos…

bf95dd8

…itioning is now right, so it is no longer needed.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Delete the old obsolte PDFGraphics2DOutputDeviceAdapter.

6db0351

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Remove the debug rectangle from the svg output. The pos…

4fa4445

…itioning is now right, so it is no longer needed.

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 19, 2017

danfickle#23: Delete the old obsolte PDFGraphics2DOutputDeviceAdapter.

d9f2b85

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 26, 2017

danfickle#23 Add the possibility to also render SVGs when drawing wit…

c2a59cf

…h Graphics2D

rototor added a commit to rototor/openhtmltopdf that referenced this issue Feb 26, 2017

danfickle#23 Add the possibility to also render SVGs when drawing wit…

f59aa7e

…h Graphics2D

rototor mentioned this issue Feb 26, 2017

Graphics2d builder and testdriver #74

Merged

danfickle mentioned this issue Apr 3, 2017

Upload to maven central via bintray. #7

Open

rototor mentioned this issue Apr 7, 2017

Feature differences between openhtmltopdf and flyingsaucer #80

Closed

danfickle closed this as completed Apr 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for SVG images #23

Add support for SVG images #23

ngns commented Apr 22, 2016

danfickle commented Apr 25, 2016

ngns commented Apr 29, 2016 •

edited

Loading

danfickle commented Jun 11, 2016

danfickle commented Jun 12, 2016 •

edited

Loading

danfickle commented Jun 15, 2016

rototor commented Sep 27, 2016

danfickle commented Sep 28, 2016

brettclark commented Jan 12, 2017

danfickle commented Jan 14, 2017

rototor commented Jan 30, 2017

rototor commented Feb 2, 2017

danfickle commented Feb 21, 2017 •

edited

Loading

pilami commented Mar 30, 2017

danfickle commented Apr 3, 2017

jmsalcido commented Feb 23, 2018

Add support for SVG images #23

Add support for SVG images #23

Comments

ngns commented Apr 22, 2016

danfickle commented Apr 25, 2016

ngns commented Apr 29, 2016 • edited Loading

danfickle commented Jun 11, 2016

danfickle commented Jun 12, 2016 • edited Loading

danfickle commented Jun 15, 2016

rototor commented Sep 27, 2016

danfickle commented Sep 28, 2016

brettclark commented Jan 12, 2017

danfickle commented Jan 14, 2017

rototor commented Jan 30, 2017

rototor commented Feb 2, 2017

danfickle commented Feb 21, 2017 • edited Loading

pilami commented Mar 30, 2017

danfickle commented Apr 3, 2017

jmsalcido commented Feb 23, 2018

ngns commented Apr 29, 2016 •

edited

Loading

danfickle commented Jun 12, 2016 •

edited

Loading

danfickle commented Feb 21, 2017 •

edited

Loading