Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check data:image type against revolved url #132

Merged
merged 1 commit into from
Sep 26, 2017
Merged

check data:image type against revolved url #132

merged 1 commit into from
Sep 26, 2017

Conversation

AlbanSeurat
Copy link
Contributor

Using URI Resolver we can change the uri and therefore my guess is that the check on image should be on the URI resolved.

For instance I have an uri with "cid" scheme which I transform into data:image as they are both kind of embedded images ...

@AlbanSeurat
Copy link
Contributor Author

@danfickle any chance to merge this PR ?

@danfickle
Copy link
Owner

Hi @AlbanSeurat

Thanks for the PR. I just have some outstanding code I need to commit before merging. I’ll try to work on it on Saturday.

@danfickle
Copy link
Owner

Thanks again @AlbanSeurat

I think this is theoretically a possibly breaking change but unlikely anybody has assumed order. I thought I would note it here, just in case. Merging now.

@danfickle danfickle merged commit b4deb3e into danfickle:open-dev-v1 Sep 26, 2017
@AlbanSeurat
Copy link
Contributor Author

@danfickle thanks

@AlbanSeurat
Copy link
Contributor Author

Any change to have 0.0.1-RC12 to be release soon ?

@danfickle
Copy link
Owner

@AlbanSeurat

Just released RC-12 now.

@AlbanSeurat
Copy link
Contributor Author

AlbanSeurat commented Nov 26, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants