September improvements by @backslash47 #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfickle
added a commit
that referenced
this pull request
Oct 18, 2017
|
Hi @backslash47 The symbol Thanks, |
danfickle
added a commit
that referenced
this pull request
Oct 19, 2017
…r images. This should allow percentage values in max-height and max-width for images. Fix suggested in #143 Thanks @backslash47
|
Hello, I did not have much time to work it into PDFBOX repo. If you can propose it to pdfbox maintainers, it would be great. |
schmitch
reviewed
Oct 24, 2017
| @@ -169,11 +179,12 @@ public PdfBoxRenderer(float dotsPerPoint, int dotsPerPixel, boolean useSubsets, | |||
| PdfBoxRenderer(BaseDocument doc, UnicodeImplementation unicode, | |||
| HttpStreamFactory httpStreamFactory, | |||
| OutputStream os, FSUriResolver resolver, FSCache cache, SVGDrawer svgImpl, | |||
| PageDimensions pageSize, float pdfVersion, String replacementText, boolean testMode, FSObjectDrawerFactory objectDrawerFactory) { | |||
| PageDimensions pageSize, float pdfVersion, String pdfAConformance, byte[] colorProfile, String replacementText, boolean testMode, FSObjectDrawerFactory objectDrawerFactory) { | |||
There was a problem hiding this comment.
I'm not sure if it is a good idea to pass the pdfAConformance as a string.
They actually barley change over the years.
|
We're now waiting on PDFBOX-3992 for the show text with positioning operator (TJ). |
danfickle
added a commit
that referenced
this pull request
Nov 25, 2017
danfickle
added a commit
that referenced
this pull request
Nov 25, 2017
danfickle
added a commit
that referenced
this pull request
Jul 3, 2018
cherry-picked commit from pr #143: bold and italic emulation
danfickle
added a commit
that referenced
this pull request
Jul 14, 2018
Cherry-pick from PR #143: pdf/a support
danfickle
added a commit
that referenced
this pull request
Aug 3, 2018
Includes support for min/max height/width properties and test cases. Limitations: + Not implemented for replaced elements such as images/MathML, etc. + Not taken into account during the table layout algorithm.
|
Should be finished with this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome work @backslash47