Add support for max-width and max-height properties on img elements

[achuinard]

This commit should allow PDF rendering to support max-width and max-height properties on img elements.

[danfickle]

Perfect! Thanks @achuinard

Merging now.

[achuinard]

Thanks. I thought that the best place to put this might have been in
BlockBox. Are images rendered as a BlockBox? Why didn't the max width and
max height properties get taken into account already?

On Nov 1, 2016 8:21 PM, "danfickle" notifications@github.com wrote:

Merged #48 #48.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAcqjyxi7tPOBptQiroUKQERVH6a6Ovvks5q5-WVgaJpZM4KmgD5
.

[danfickle]

Images are rendered as special replaced elements (like form controls). I think this was how it was specified in an old HTML standard. We might have to revisit this if we want to apply other CSS on the img element such as transform.

[achuinard]

Sounds good. How does the release cycle work? Will RC8 be pushed to the repository?

[danfickle]

I'd prefer to not make a release so soon after the last.
Can you get away with wrapping the image in a block?

<div style="max-width: 80px;">
  <img src="image.png" alt="title" style="width: 100%;"/>
</div>

[achuinard]

Can you release the new version to Maven?

[danfickle]

Hi @achuinard
I've got some uncommitted code for CSS transforms that I'm working on. Can you wait a couple of days or do you need a release for Monday?

[achuinard]

I can wait til end of week at latest.

On Nov 19, 2016 9:23 PM, "danfickle" notifications@github.com wrote:

Hi @achuinard https://github.com/achuinard
I've got some uncommitted code for CSS transforms that I'm working on. Can
you wait a couple of days or do you need a release for Monday?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#48 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcqjyHZ84eqICNVd8OpfbcS8X6uqnZYks5q_71CgaJpZM4KmgD5
.