#493 Auto extraction of SVG styles to pass to Batik SVG renderer. #515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #493 #496
When merged it will be possible to specify CSS styles for SVG images in the document's style tag or linked or imported style sheets. For example, these will work for SVG images inline in the XHTML:
For performance reasons, I decided not to inject top level selectors, so this WILL NOT work:
Specifically, CSS selectors targeting SVG objects must be preceded by a selector that targets the SVG element itself. Otherwise, we would have to dump nearly everything into the SVG CSS.
SVG elements injected via the img tag src attribute
SVG objects such as
circle
inside an SVG file linked from theimg
tag can also be styled. However, in this case the SVG XML is detached from the XHTML so descendant and direct child selectors will not work. Theclass
attribute is specifically copied across so that these SVGs can be targetted.Example
Limitations: