Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log message id format: use static final + add test #554

Merged
merged 1 commit into from
Sep 18, 2020
Merged

log message id format: use static final + add test #554

merged 1 commit into from
Sep 18, 2020

Conversation

syjer
Copy link
Contributor

@syjer syjer commented Sep 14, 2020

I noticed that in #552 that I forgot to set as "static" the placeholder.

Additionally, I've added some tests.

@danfickle
Copy link
Owner

Thanks again. Very concientious!

@danfickle danfickle merged commit 1e96fb8 into danfickle:open-dev-v1 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants