#599 Increment _end in trimLeadingSpace #604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increment LineBreakContext ending when trimming leading space. When a tag only has spaces, e.g. an entity, the result was an ending smaller than a start, causing a RuntimeException.
danfickle
added a commit
that referenced
this pull request
Nov 20, 2020
Thanks for debugging and suggesting fix @LAlves91.
|
Thanks again @LAlves91. I think we can close this PR and related issue now. It should be fixed. |
|
Thank you @danfickle ! Is there a planned date to release the next version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increment LineBreakContext ending when trimming leading space. When a tag only has spaces, e.g. an entity, the result was an ending smaller than a start, causing a RuntimeException.