Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #641
Including major refactor of PDF font resolver and passing test.
Why it is required:
Currently fonts not matching the specified
font-family
in CSS are not used. This PR allows one to register fonts to be used in the event that there are no fonts which match thefont-family
and support the current character.Fallback fonts can be registered to try before the built-in fonts (
FALLBACK_PRE
) or after (FALLBACK_FINAL
).We can now do:
Fallback fonts are sorted from lowest priority to highest. The inputs are provided from CSS.