Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#700 Timeouts for the default http, https protocol handler. #702

Merged
merged 1 commit into from
May 22, 2021
Merged

#700 Timeouts for the default http, https protocol handler. #702

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 30 additions & 1 deletion openhtmltopdf-core/src/main/java/com/openhtmltopdf/swing/NaiveUserAgent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import java.net.URI;
import java.net.URISyntaxException;
import java.net.URL;
import java.net.URLConnection;
import java.nio.charset.StandardCharsets;
import java.util.EnumMap;
import java.util.HashMap;
Expand Down Expand Up @@ -95,13 +96,41 @@ public Reader getReader() {
}

public static class DefaultHttpStreamFactory implements FSStreamFactory {
final static int CONNECTION_TIMEOUT = 10_000;
final static int READ_TIMEOUT = 30_000;

final int connectTimeout;
final int readTimeout;

/**
* Create a FSStreamFactory for http, https with specified timeouts.
* Uses URLConnection to perform requests.
* Zero value for timeout specifies no timeout.
*/
public DefaultHttpStreamFactory(int connectTimeout, int readTimeout) {
this.connectTimeout = connectTimeout;
this.readTimeout = readTimeout;
}

/**
* Create a FSStreamFactory with 10 second connect timeout and
* 30 second read timeout.
*/
public DefaultHttpStreamFactory() {
this(CONNECTION_TIMEOUT, READ_TIMEOUT);
}

@Override
public FSStream getUrl(String uri) {
InputStream is = null;

try {
is = new URL(uri).openStream();
URLConnection conn = new URL(uri).openConnection();
conn.setConnectTimeout(this.connectTimeout);
conn.setReadTimeout(this.readTimeout);
conn.connect();

is = conn.getInputStream();
} catch (java.net.MalformedURLException e) {
XRLog.log(Level.WARNING, LogMessageId.LogMessageId1Param.EXCEPTION_MALFORMED_URL, uri, e);
} catch (java.io.FileNotFoundException e) {
Expand Down