Custom object drawers #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a default factory for FSObjectDrawer, which allows to register custom drawers. The testrunner includes a simple example how to implement a FSObjectDrawer. Currently its only possible with the PdfBoxRendererBuilder to register a FSObjectDrawerFactory. As soon as danfickle#77 is merged I will implement the same for Java2D. This is the final feature I need to migrate all my reports to OpenHtmlToPdf, as we do some custom graphs in some reports.
…ct-drawers # Conflicts: # openhtmltopdf-core/src/main/java/com/openhtmltopdf/simple/Java2DRenderer Builder.java
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement ObjectDrawer for <object> tags.
Implement a default factory for FSObjectDrawer, which allows to register custom drawers.
The testrunner includes a simple example how to implement a FSObjectDrawer.
Currently its only possible with the PdfBoxRendererBuilder to register a FSObjectDrawerFactory. As soon as #77 is merged I will implement the same for Java2D.
This is the final feature I need to migrate all my reports to OpenHtmlToPdf, as we do some custom graphs in some reports.
I hope you don't mind the auto organize of imports, which IDEA does all the time ... Otherwise I will try to minimize the import changes.