Hostname option for generating self-signed certificates on the fly. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, add `allowAny`, though it requires another tweak to actually work.
Also add `checkIpAddressOrNull()`.
As of this writing, there's a deficiency in that the resulting certificate causes bad behavior when asked to be used for IP addresses. See TODO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main point of this PR was to make it possible for the system to generate self-signed certificates on the fly, but I ended up also diving into how hostnames and IP addresses are parsed and fixing that up quite a bit.
As of this PR, there's a problem with self-signed certs (as generated by this code) when trying to use them with IP-address-only (that is, no DNS name) incoming requests. There's a TODO in the code to remind me to figure it out… in the fullness of time.