J'accuse pem!
#375
Merged
J'accuse pem!
#375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
pem's main export will install its own globalprocess.emitsource map handler, for who-the-muffin-knows-why. But in any case, (a) it shouldn't, but thankfully (b) it's at least possible to avoid it doing that. So this PR avoids the installation and adds a test to make sure it doesn't start happening again. FWIW I was a bit wary when I started usingpemin the first place, and this experience makes me reluctant to leave it in, in the long term.See Dexus/pem#389 and jestjs/jest#15077 for more details. And thanks very much to @SimenB and @nwalters512 for their assistance.