[Maintenance] Switch to node-14 as the oldest tested environment #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create-react-apprequires >= node-14, and our test-CI workflow requires create-react-app to succeed. See the CI failure in #1188This PR upgrades all the node-versions that I could find from 10, 10.3, or unspecified, to node 14.
Alternatives
A. only upgrade the CI for that particular GitHub action workflow
B. upgrade to node-16 (14 has already been in maintenance mode for a long time)
C. upgrade to node-17
D. upgrade to node-18 (18 won't enter LTS until October)
E. Delete the create-react-app test case
Node Version Chart
We could also add an entry to our package.json
enginesto express whichever decision we make.Blocking
This PR Blocks: #1176, #1186, #1188, #1190, and any future PRs from going green in CI