chore: Switch from tslint to eslint #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tslint is end-of-life, and warns when you install it. Additionally, the version we were on didn't support 'import type' expressions, as well as optional-chaining & null coalescing when I tried to use those in #1204 This PR does update a bunch of tslint-disable comments, but otherwise tries to minimally change runtime source in danger-js. If we want to tighten the eslint rules, I'd be super supportive, but I didn't want to cause a ton of thrash, so mostly the rules that are enabled are the ones that don't trigger on tons of existing code.
orta
reviewed
Feb 2, 2022
| dataSent.settings.github.accessToken = "12345" | ||
|
|
||
| writeFileSync(pathJoin(fixtures, "bbc-dsl-input.json"), JSON.stringify(dataSent, null, " "), "utf8") | ||
| }).not.toThrow() |
|
Perfect PR. WRT to tightening the linter rules, call me lightly supportive - I mostly disable eslint/tslint on repos I run nowadays because 'I know better' (aka, since I joined TS I mostly only write repos where I'm the core author and so I don't have to share well with others) so you're welcome to do it (in part because you're writing most new code in danger ATM) but know that I'm a sledgehammer who might just turn it off for sections I write :D |
|
I couldn't find an email for you - but the danger slack seems to have got a bit more active over the last week or two, so you might enjoy having access too ( send me a "hey" email to the mail in my GitHub bio @orta) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tslint is end-of-life, and warns when you install it. Additionally, the version we were on didn't support 'import type' expressions, as well as optional-chaining & null coalescing when I tried to use those in #1204
This PR does update a bunch of tslint-disable comments, but otherwise tries to minimally change runtime source in danger-js. If we want to tighten the eslint rules, I'd be super supportive, but I didn't want to cause a ton of thrash, so mostly the rules that are enabled are the ones that don't trigger on tons of existing code.
This PR also upgrades prettier, because that was needed to handle
readonly string[]arguments.Be aware this PR drops testing support for node 10 in AppVeyor -- b66f86f
@typescript-eslintdoesn't support node 10