Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print default base branch for danger local #1251

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Print default base branch for danger local #1251

merged 1 commit into from
Mar 15, 2022

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 15, 2022

This uses commander default argument value.

This uses commander default argument value
@glensc glensc self-assigned this Mar 15, 2022
@glensc
Copy link
Contributor Author

glensc commented Mar 15, 2022

oh wow, pretty old commander.js in this project:

considering that latest is 9:

@glensc glensc marked this pull request as ready for review March 15, 2022 13:39
@glensc
Copy link
Contributor Author

glensc commented Mar 15, 2022

I don't know how to test that commandline change, couldn't find anything useful in CONTRIBUTING.md

@orta
Copy link
Member

orta commented Mar 15, 2022

Seems like a reasonable change to me 👍🏻 thanks

We don't really have any tests at the CLI level, given that it's usually just a quick jump into app code

@orta orta merged commit d313d16 into main Mar 15, 2022
@orta
Copy link
Member

orta commented Mar 15, 2022

I don't really get on the npm rat race for dependencies unless there is a real CVE which I think is important to update, you're welcome to take a look at updating

@fbartho fbartho deleted the glensc-patch-1 branch March 15, 2022 17:00
@glensc
Copy link
Contributor Author

glensc commented Mar 15, 2022

I've updated to 8.x recently (but from 6.x), adds $this->option -> $this->opts()->option change mostly, the other majro version bumps are due dropped node versions, i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants