Remove implict git add when running pre-commit hooks #1260
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code (before this PR) breaks the intended behavior committing staged changes.
I strive for atomic commits:
so, I make changes,
git add -p
to stage changes for intended commit, and then dogit commit
. now thepre-commit
hook will override mygit add -p
staging adding all modified files to commit.this is unexpected and even hidden, so wouldn't even know something override my staging.
combining lint-staged update to v10, would have the best experience as it will automatically stage the changes, made in scripts ran by lint staged: