fix: reject with real errors for GitLab API calls for better debugging #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In previous implementation, some GitLab API calls would make a Promise rejection with `undefined` as the reason. And in the [global `unhandledRejection` handler](https://github.com/frantic1048/danger-js/blob/b67d710af4d177d57e7091a742da54a2e9fa37fc/source/commands/utils/sharedDangerfileArgs.ts#L5), it will print a generic "Error: undefined" message. This makes debugging very hard. This commit fixes the issue by filling in the rejection reason with the actual error.
frantic1048
force-pushed
the
fix/reject-with-real-gitlab-api-errors
branch
from
e680d73
to
b62df49
Compare
|
Yeah, this makes sense 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, some GitLab API calls would make a Promise rejection with
undefinedas the reason.And in the global
unhandledRejectionhandler, it will print a generic "Error: undefined" message.This makes debugging very hard.
This commit fixes the issue by filling in the rejection reason with the actual error.