Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(danger-kotlin): allow to add space separated args #247

Merged
merged 1 commit into from
May 26, 2023
Merged

fix(danger-kotlin): allow to add space separated args #247

merged 1 commit into from
May 26, 2023

Conversation

Vacxe
Copy link
Member

@Vacxe Vacxe commented May 26, 2023

Fixing issue with space separated args.
For example Kotlin CLI: ... --id "My space separated ID" -> JS CLI: --id My space separated ID
It can create issue as well if space separated args will be added in the middle of parameters string
F.E. --id "My space separated ID" --danger-file /foo/d.df.kts

@Vacxe Vacxe requested a review from f-meloni May 26, 2023 00:26
Copy link
Member

@f-meloni f-meloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@f-meloni f-meloni merged commit 4c5972b into danger:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants