Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): missed default serialisation values #281

Merged
merged 1 commit into from
Apr 24, 2024
Merged

fix(core): missed default serialisation values #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/github/GitHub.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ enum class GitHubPullRequestState {
data class GitHubPR(
val number: Int,
val title: String,
val body: String?,
val body: String? = null,
val user: GitHubUser,
val assignee: GitHubUser?,
val assignee: GitHubUser? = null,
val assignees: List<GitHubUser>,
@SerialName("created_at") val createdAt: Instant,
@SerialName("updated_at") val updatedAt: Instant,
Expand All @@ -78,14 +78,14 @@ data class GitHubPR(
val state: GitHubPullRequestState,
@SerialName("draft") val isDraft: Boolean,
@SerialName("locked") val isLocked: Boolean,
@SerialName("merged") val isMerged: Boolean?,
@SerialName("commits") val commitCount: Int?,
@SerialName("comments") val commentCount: Int?,
@SerialName("review_comments") val reviewCommentCount: Int?,
val additions: Int?,
val deletions: Int?,
@SerialName("changed_files") val changedFiles: Int?,
val milestone: GitHubMilestone?,
@SerialName("merged") val isMerged: Boolean? = null,
@SerialName("commits") val commitCount: Int? = null,
@SerialName("comments") val commentCount: Int? = null,
@SerialName("review_comments") val reviewCommentCount: Int? = null,
val additions: Int? = null,
val deletions: Int? = null,
@SerialName("changed_files") val changedFiles: Int? = null,
val milestone: GitHubMilestone? = null,
@SerialName("html_url") val htmlURL: String
)

Expand Down Expand Up @@ -150,7 +150,7 @@ data class GitHubRepo(
val fullName: String,
@SerialName("private")
val isPrivate: Boolean,
val description: String?,
val description: String? = null,
@SerialName("fork")
val isFork: Boolean,
@SerialName("html_url")
Expand Down Expand Up @@ -178,10 +178,11 @@ enum class GitHubReviewState {
@Serializable
data class GitHubReview(
val user: GitHubUser,
val id: Long?,
val body: String?,
@SerialName("commit_id") val commitId: String?,
val state: GitHubReviewState?
val id: Long? = null,
val body: String? = null,
@SerialName("commit_id")
val commitId: String? = null,
val state: GitHubReviewState? = null
)

/**
Expand All @@ -197,9 +198,9 @@ data class GitHubReview(
data class GitHubCommit(
val sha: String,
val url: String,
val author: GitHubUser?,
val author: GitHubUser? = null,
val commit: GitCommit,
val committer: GitHubUser?
val committer: GitHubUser? = null
)

@Serializable
Expand Down Expand Up @@ -248,11 +249,11 @@ data class GitHubIssue(
val user: GitHubUser,
val state: GitHubIssueState,
@SerialName("locked") val isLocked: Boolean,
val body: String?,
val body: String? = null,
@SerialName("comments") val commentCount: Int,
val assignee: GitHubUser?,
val assignee: GitHubUser? = null,
val assignees: List<GitHubUser>,
val milestone: GitHubMilestone?,
val milestone: GitHubMilestone? = null,
@SerialName("created_at") val createdAt: Instant,
@SerialName("updated_at") val updatedAt: Instant,
@SerialName("closed_at") val closedAt: Instant? = null,
Expand Down Expand Up @@ -294,9 +295,9 @@ enum class GitHubUserType {
*/
@Serializable
data class GitHubUser(
val id: Long?,
val login: String?,
val type: GitHubUserType?,
val id: Long? = null,
val login: String? = null,
val type: GitHubUserType? = null,
@SerialName("avatar_url")
val avatarUrl: String?
)
Expand Down
2 changes: 1 addition & 1 deletion danger-kotlin-library/src/main/kotlin/systems/danger/kotlin/models/gitlab/GitLab.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ data class GitLabMergeRequest(
@SerialName("first_deployed_to_production_at")
val firstDeployedToProductionAt: Instant? = null,
@SerialName("force_remove_source_branch")
val forceRemoveSourceBranch: Boolean?,
val forceRemoveSourceBranch: Boolean? = null,
val id: Int,
val iid: Int,
@SerialName("latest_build_finished_at")
Expand Down