-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a decode error with BitBucket server #553
Fix a decode error with BitBucket server #553
Conversation
b5d1359
to
d7c3007
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Could you please add a test for this? (not a blocker)
a929fc9
to
c7b284f
Compare
c7b284f
to
87916ae
Compare
I can't find why CI failed though got no errors locally.. |
Posted issue since I found an issue on CI pipeline #556 |
…m/pepix/dangerswift into fix-bitbucket-server-decode-error
I have made few changes to reduce the noise made from swiftlint and swiftformat, I will merge this so that it can make it in the release and work on swiftlint as a separated issue. |
Issue
I faced a decode error when I run
$ danger-swift pr <pr_url>
for a certain pull request in GitBucket Server.As my investigation, it seems they don't return
public
field if that repository is forked by someone.After I made it optional, it works.