Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: GitHub.Review.submittedAt may be nil #624

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Fix: GitHub.Review.submittedAt may be nil #624

merged 4 commits into from
Oct 14, 2024

Conversation

417-72KI
Copy link
Member

submittedAt property on some review objects may be nil before submitted.
ref: https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#get-a-review-for-a-pull-request

@417-72KI 417-72KI marked this pull request as ready for review September 27, 2024 15:15
@f-meloni f-meloni merged commit c8d2aeb into danger:master Oct 14, 2024
14 checks passed
@417-72KI 417-72KI deleted the review-before-submmitted branch October 16, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-meloni f-meloni f-meloni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@417-72KI @f-meloni