Support skipLabels that contain forward slash #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
Preview of Release Notes to be CreatedChnaged
Dependencies
|
dangoslen
reviewed
Jul 20, 2023
|
|
||
| it('should handle labels containing a forward slash', () => { |
| @@ -2,7 +2,7 @@ module.exports.extractLabels = function (labelsString) { | |||
| // Parses a list of labels. Each label can be of any length and will either end with a comma or be the end of the string. | |||
| // Matches words (\w), whitespace characters (\s), dashes (-), plus signs (+), questions marks (\?), semi-colons (;), brackets (\[\]) and parenthesis (\(\)) | |||
| // Each match may are may not have a trailing comma (,?). If one exists, it is removed before appending it to the list | |||
| const regex = new RegExp(/([\w\s-+\?;\[\]\(\)]+,?)/, 'g') | |||
| const regex = new RegExp(/([\w\s-\/+\?;\[\]\(\)]+,?)/, 'g') | |||
There was a problem hiding this comment.
👍🏼 Thank you.
Only thing is can we update the comment on line 3 to point out / now matches?
Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
|
Will merge and put this in the next release. Thinking a 3.5.0 since I don't see it as a patch but an improvement to support more label names |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skipLabelscurrently splits labels that contain/into multiple labels soskip/changelogbecomesskip, changelog. This change fixes that so that a singleskip/changelog(for example) label can be used.