Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git ownership issue #44

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Fix git ownership issue #44

merged 7 commits into from
Jan 31, 2023

Conversation

zepfietje
Copy link
Contributor

@zepfietje zepfietje commented Jan 31, 2023

This PR attempts to fix fixes #36.
Running the git command in our own workflow doesn't work, since it needs to be run inside the Docker container.

I'm not entirely sure if this fixes the issue, but this comment says it should: actions/runner-images#6775 (comment).

@zepfietje
Copy link
Contributor Author

Confirmed it fixes the issue now. @TomasVotruba

@zepfietje zepfietje marked this pull request as draft January 31, 2023 20:09
@zepfietje zepfietje marked this pull request as ready for review January 31, 2023 20:25
@TomasVotruba TomasVotruba merged commit ac98452 into danharrin:main Jan 31, 2023
@TomasVotruba
Copy link
Collaborator

Thank you... lets give this a try 👍

@SerafimArts
Copy link

SerafimArts commented Feb 1, 2023

Just ran into this problem and couldn't fix it. Thank you very much for this fix!

But...

Config:
uses: symplify/github-action-monorepo-split@2.3

Result:

Unable to resolve action danharrin/monorepo-split-github-action@2.3, unable to find version 2.3

Can you tell me pls what I'm doing wrong?

P.S. In case of:
symplify/github-action-monorepo-split@2.3.0 (instead @2.3) I am getting the same error

@zepfietje
Copy link
Contributor Author

@SerafimArts, this repo was transferred to @danharrin.
Make sure to use the new action namespace: danharrin/monorepo-split-github-action@v2.3.0.

@SerafimArts
Copy link

SerafimArts commented Feb 1, 2023

Oh! You changed the naming of the tags (prefix "v" has been added), did not notice.

Before: 1.0.x ... 2.2.x
After: v2.3.x

Is it just me or is this a mistake in the tag name?

@zepfietje
Copy link
Contributor Author

It's on purpose, @SerafimArts.

@SerafimArts
Copy link

SerafimArts commented Feb 1, 2023

Ok =)

Just please note that in this case using the old symplify/github-action-monorepo-split@2 action will use 2.2 and is not compatible with the current v2.3.

P.S. The same applies to the current README, it is not compatible with the new tag naming.

@andrew-belac
Copy link

andrew-belac commented Feb 1, 2023

@danharrin thank you for taking over the repo. @zepfietje thank you for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detected dubious ownership in repository
4 participants