New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rust and Crates #3808

Merged

dani-garcia merged 1 commit into dani-garcia:main from BlackDex:update-rust-and-crates

Aug 31, 2023

Collaborator

BlackDex commented Aug 28, 2023

Updated Rust to v1.72.0
Updated all the crates Including a CVE https://github.com/dani-garcia/vaultwarden/security/dependabot/21
Updated GitHub Workflows
Run cargo fmt which has some new fmt's
Moved from rust-toolchain to rust-toolchain.toml

BlackDex force-pushed the update-rust-and-crates branch from b00f31d to c910063 Compare

August 28, 2023 16:14

Contributor

tessus commented Aug 28, 2023

@BlackDex I remember you mentioned that the following crates are not updated due to breaking changes: webauthn-rs, cookie, cookie_store. Wouldn't it still makes sense to update them and adjust the vw code accordingly? Or would the changes to the code be that complex?

Collaborator Author

BlackDex commented Aug 28, 2023

@BlackDex I remember you mentioned that the following crates are not updated due to breaking changes: webauthn-rs, cookie, cookie_store. Wouldn't it still makes sense to update them and adjust the vw code accordingly? Or would the changes to the code be that complex?

The cookie crates are tied to Reqwest, so that has to be updated first by that crate before we can. Same btw for thungstintie, that needs to be update by Rocket first.

For webauthn we need to create a migration like we did before, we even need to be sure we can migrate both versions to the new way.

So, all of those are currently not an option to be updated right now.

But, thanks for mentioning.

BlackDex force-pushed the update-rust-and-crates branch 7 times, most recently from c123990 to 0c53b81 Compare

August 31, 2023 20:06


          Update Rust and Crates

32543c4

- Updated Rust to v1.72.0
- Updated all the crates
  Including a CVE https://github.com/dani-garcia/vaultwarden/security/dependabot/21
- Updated GitHub Workflows
- Run `cargo fmt` which has some new fmt's
- Moved from `rust-toolchain` to `rust-toolchain.toml`

BlackDex force-pushed the update-rust-and-crates branch from 0c53b81 to 32543c4 Compare

August 31, 2023 20:46

dani-garcia approved these changes

View reviewed changes

dani-garcia merged commit ad2cfd8 into dani-garcia:main

BlackDex deleted the update-rust-and-crates branch

August 31, 2023 22:09

jayknyn pushed a commit to ayamsecure/secrets that referenced this pull request


          Merge pull request dani-garcia#3808 from BlackDex/update-rust-and-crates

6fe4009

Update Rust and Crates

arthurgeek referenced this pull request in arthurgeek/vaultwarden-fly-template


          feat(container): update image vaultwarden/server to v1.30.0 (#25)

1eacefc

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) |
stage | minor | `1.29.2-alpine` -> `1.30.0-alpine` |

---

### Release Notes

<details>
<summary>dani-garcia/vaultwarden (vaultwarden/server)</summary>

###
[`v1.30.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.0)

[Compare
Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.29.2...1.30.0)

⚠️ **Note:** The WebSockets service for live sync has been integrated in
the main HTTP server, which means simpler proxy setups that don't
require a separate rule to redirect WS traffic to port 3012. Please
check the updated examples in the
[wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples).
It's recommended to migrate to this new setup as using the old server on
port 3012 is deprecated, won't receive new features and will be removed
in a future release.

#### Major changes and New Features

- Added `passkey` support, allowing the browser extensions to store and
use your `passkeys`, make sure the extension is updated to version
`2023.10.0` or newer for passkey support.
-   Updated web vault to 2023.10.0.
-   Fixed crashes in ARMv6 devices
- Fixed crashes when trying to create/edit a cipher in the mobile
applications.

#### What's Changed

- Update Rust and Crates by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3808](https://togithub.com/dani-garcia/vaultwarden/pull/3808)
- update web-vault to v2023.8.2 by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3821](https://togithub.com/dani-garcia/vaultwarden/pull/3821)
- Fix Login With Device without MasterPassword by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3831](https://togithub.com/dani-garcia/vaultwarden/pull/3831)
- Update GitHub Workflow by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3910](https://togithub.com/dani-garcia/vaultwarden/pull/3910)
- Fix arm builds by [@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3911](https://togithub.com/dani-garcia/vaultwarden/pull/3911)
- Fix typos by [@&#8203;tuhanayim](https://togithub.com/tuhanayim) in
[https://github.com/dani-garcia/vaultwarden/pull/3959](https://togithub.com/dani-garcia/vaultwarden/pull/3959)
- csp: rename anonaddy.com to addy.io by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3950](https://togithub.com/dani-garcia/vaultwarden/pull/3950)
- filter handlebars logs by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3859](https://togithub.com/dani-garcia/vaultwarden/pull/3859)
- Remove unnecessary variable clone by
[@&#8203;mvalois](https://togithub.com/mvalois) in
[https://github.com/dani-garcia/vaultwarden/pull/3981](https://togithub.com/dani-garcia/vaultwarden/pull/3981)
- README.md: Fix grammar nit by
[@&#8203;AndreasHGK](https://togithub.com/AndreasHGK) in
[https://github.com/dani-garcia/vaultwarden/pull/3965](https://togithub.com/dani-garcia/vaultwarden/pull/3965)
- Fix small issues by [@&#8203;BlackDex](https://togithub.com/BlackDex)
in
[https://github.com/dani-garcia/vaultwarden/pull/3964](https://togithub.com/dani-garcia/vaultwarden/pull/3964)
- Adds LastActive on /admin/users API route by
[@&#8203;mvalois](https://togithub.com/mvalois) in
[https://github.com/dani-garcia/vaultwarden/pull/3951](https://togithub.com/dani-garcia/vaultwarden/pull/3951)
- Reopen log file on SIGHUP by
[@&#8203;tobiasmboelz](https://togithub.com/tobiasmboelz) in
[https://github.com/dani-garcia/vaultwarden/pull/3909](https://togithub.com/dani-garcia/vaultwarden/pull/3909)
- Fix External ID not set during DC Sync by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3804](https://togithub.com/dani-garcia/vaultwarden/pull/3804)
- New config option disable email change by
[@&#8203;admav](https://togithub.com/admav) in
[https://github.com/dani-garcia/vaultwarden/pull/3986](https://togithub.com/dani-garcia/vaultwarden/pull/3986)
- 2FA Confirmation Code Email subject line change to fix triggering
Google spam blocker by
[@&#8203;aureateflux](https://togithub.com/aureateflux) in
[https://github.com/dani-garcia/vaultwarden/pull/3572](https://togithub.com/dani-garcia/vaultwarden/pull/3572)
- Implement cipher key encryption by
[@&#8203;dani-garcia](https://togithub.com/dani-garcia) in
[https://github.com/dani-garcia/vaultwarden/pull/3990](https://togithub.com/dani-garcia/vaultwarden/pull/3990)
- Container building changes by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3958](https://togithub.com/dani-garcia/vaultwarden/pull/3958)
- Fix issue with MariaDB/MySQL migrations by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3994](https://togithub.com/dani-garcia/vaultwarden/pull/3994)
- feat: Working passkeys storage by
[@&#8203;GeekCornerGH](https://togithub.com/GeekCornerGH) in
[https://github.com/dani-garcia/vaultwarden/pull/4025](https://togithub.com/dani-garcia/vaultwarden/pull/4025)
- ci: add trivy workflow by
[@&#8203;mightyBroccoli](https://togithub.com/mightyBroccoli) in
[https://github.com/dani-garcia/vaultwarden/pull/3997](https://togithub.com/dani-garcia/vaultwarden/pull/3997)
- Fix importing Bitwarden exports by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/4030](https://togithub.com/dani-garcia/vaultwarden/pull/4030)

#### New Contributors

- [@&#8203;tuhanayim](https://togithub.com/tuhanayim) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3959](https://togithub.com/dani-garcia/vaultwarden/pull/3959)
- [@&#8203;mvalois](https://togithub.com/mvalois) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3981](https://togithub.com/dani-garcia/vaultwarden/pull/3981)
- [@&#8203;AndreasHGK](https://togithub.com/AndreasHGK) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3965](https://togithub.com/dani-garcia/vaultwarden/pull/3965)
- [@&#8203;tobiasmboelz](https://togithub.com/tobiasmboelz) made their
first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3909](https://togithub.com/dani-garcia/vaultwarden/pull/3909)
- [@&#8203;admav](https://togithub.com/admav) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3986](https://togithub.com/dani-garcia/vaultwarden/pull/3986)
- [@&#8203;aureateflux](https://togithub.com/aureateflux) made their
first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3572](https://togithub.com/dani-garcia/vaultwarden/pull/3572)
- [@&#8203;mightyBroccoli](https://togithub.com/mightyBroccoli) made
their first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3997](https://togithub.com/dani-garcia/vaultwarden/pull/3997)

**Full Changelog**:
dani-garcia/vaultwarden@1.29.2...1.30.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly-template).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

arthurgeek referenced this pull request in arthurgeek/vaultwarden-fly


          feat(container): update image vaultwarden/server to v1.30.0 (#16)

4394e56

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [vaultwarden/server](https://togithub.com/dani-garcia/vaultwarden) |
stage | minor | `1.29.2-alpine` -> `1.30.0-alpine` |

---

### Release Notes

<details>
<summary>dani-garcia/vaultwarden (vaultwarden/server)</summary>

###
[`v1.30.0`](https://togithub.com/dani-garcia/vaultwarden/releases/tag/1.30.0)

[Compare
Source](https://togithub.com/dani-garcia/vaultwarden/compare/1.29.2...1.30.0)

⚠️ **Note:** The WebSockets service for live sync has been integrated in
the main HTTP server, which means simpler proxy setups that don't
require a separate rule to redirect WS traffic to port 3012. Please
check the updated examples in the
[wiki](https://togithub.com/dani-garcia/vaultwarden/wiki/Proxy-examples).
It's recommended to migrate to this new setup as using the old server on
port 3012 is deprecated, won't receive new features and will be removed
in a future release.

#### Major changes and New Features

- Added `passkey` support, allowing the browser extensions to store and
use your `passkeys`, make sure the extension is updated to version
`2023.10.0` or newer for passkey support.
-   Updated web vault to 2023.10.0.
-   Fixed crashes in ARMv6 devices
- Fixed crashes when trying to create/edit a cipher in the mobile
applications.

#### What's Changed

- Update Rust and Crates by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3808](https://togithub.com/dani-garcia/vaultwarden/pull/3808)
- update web-vault to v2023.8.2 by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3821](https://togithub.com/dani-garcia/vaultwarden/pull/3821)
- Fix Login With Device without MasterPassword by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3831](https://togithub.com/dani-garcia/vaultwarden/pull/3831)
- Update GitHub Workflow by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3910](https://togithub.com/dani-garcia/vaultwarden/pull/3910)
- Fix arm builds by [@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3911](https://togithub.com/dani-garcia/vaultwarden/pull/3911)
- Fix typos by [@&#8203;tuhanayim](https://togithub.com/tuhanayim) in
[https://github.com/dani-garcia/vaultwarden/pull/3959](https://togithub.com/dani-garcia/vaultwarden/pull/3959)
- csp: rename anonaddy.com to addy.io by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3950](https://togithub.com/dani-garcia/vaultwarden/pull/3950)
- filter handlebars logs by
[@&#8203;stefan0xC](https://togithub.com/stefan0xC) in
[https://github.com/dani-garcia/vaultwarden/pull/3859](https://togithub.com/dani-garcia/vaultwarden/pull/3859)
- Remove unnecessary variable clone by
[@&#8203;mvalois](https://togithub.com/mvalois) in
[https://github.com/dani-garcia/vaultwarden/pull/3981](https://togithub.com/dani-garcia/vaultwarden/pull/3981)
- README.md: Fix grammar nit by
[@&#8203;AndreasHGK](https://togithub.com/AndreasHGK) in
[https://github.com/dani-garcia/vaultwarden/pull/3965](https://togithub.com/dani-garcia/vaultwarden/pull/3965)
- Fix small issues by [@&#8203;BlackDex](https://togithub.com/BlackDex)
in
[https://github.com/dani-garcia/vaultwarden/pull/3964](https://togithub.com/dani-garcia/vaultwarden/pull/3964)
- Adds LastActive on /admin/users API route by
[@&#8203;mvalois](https://togithub.com/mvalois) in
[https://github.com/dani-garcia/vaultwarden/pull/3951](https://togithub.com/dani-garcia/vaultwarden/pull/3951)
- Reopen log file on SIGHUP by
[@&#8203;tobiasmboelz](https://togithub.com/tobiasmboelz) in
[https://github.com/dani-garcia/vaultwarden/pull/3909](https://togithub.com/dani-garcia/vaultwarden/pull/3909)
- Fix External ID not set during DC Sync by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3804](https://togithub.com/dani-garcia/vaultwarden/pull/3804)
- New config option disable email change by
[@&#8203;admav](https://togithub.com/admav) in
[https://github.com/dani-garcia/vaultwarden/pull/3986](https://togithub.com/dani-garcia/vaultwarden/pull/3986)
- 2FA Confirmation Code Email subject line change to fix triggering
Google spam blocker by
[@&#8203;aureateflux](https://togithub.com/aureateflux) in
[https://github.com/dani-garcia/vaultwarden/pull/3572](https://togithub.com/dani-garcia/vaultwarden/pull/3572)
- Implement cipher key encryption by
[@&#8203;dani-garcia](https://togithub.com/dani-garcia) in
[https://github.com/dani-garcia/vaultwarden/pull/3990](https://togithub.com/dani-garcia/vaultwarden/pull/3990)
- Container building changes by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3958](https://togithub.com/dani-garcia/vaultwarden/pull/3958)
- Fix issue with MariaDB/MySQL migrations by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/3994](https://togithub.com/dani-garcia/vaultwarden/pull/3994)
- feat: Working passkeys storage by
[@&#8203;GeekCornerGH](https://togithub.com/GeekCornerGH) in
[https://github.com/dani-garcia/vaultwarden/pull/4025](https://togithub.com/dani-garcia/vaultwarden/pull/4025)
- ci: add trivy workflow by
[@&#8203;mightyBroccoli](https://togithub.com/mightyBroccoli) in
[https://github.com/dani-garcia/vaultwarden/pull/3997](https://togithub.com/dani-garcia/vaultwarden/pull/3997)
- Fix importing Bitwarden exports by
[@&#8203;BlackDex](https://togithub.com/BlackDex) in
[https://github.com/dani-garcia/vaultwarden/pull/4030](https://togithub.com/dani-garcia/vaultwarden/pull/4030)

#### New Contributors

- [@&#8203;tuhanayim](https://togithub.com/tuhanayim) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3959](https://togithub.com/dani-garcia/vaultwarden/pull/3959)
- [@&#8203;mvalois](https://togithub.com/mvalois) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3981](https://togithub.com/dani-garcia/vaultwarden/pull/3981)
- [@&#8203;AndreasHGK](https://togithub.com/AndreasHGK) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3965](https://togithub.com/dani-garcia/vaultwarden/pull/3965)
- [@&#8203;tobiasmboelz](https://togithub.com/tobiasmboelz) made their
first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3909](https://togithub.com/dani-garcia/vaultwarden/pull/3909)
- [@&#8203;admav](https://togithub.com/admav) made their first
contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3986](https://togithub.com/dani-garcia/vaultwarden/pull/3986)
- [@&#8203;aureateflux](https://togithub.com/aureateflux) made their
first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3572](https://togithub.com/dani-garcia/vaultwarden/pull/3572)
- [@&#8203;mightyBroccoli](https://togithub.com/mightyBroccoli) made
their first contribution in
[https://github.com/dani-garcia/vaultwarden/pull/3997](https://togithub.com/dani-garcia/vaultwarden/pull/3997)

**Full Changelog**:
dani-garcia/vaultwarden@1.29.2...1.30.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At
any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/arthurgeek/vaultwarden-fly).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet