Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click event not fired [almost always] on Android > 4.4.4 #768

Closed
tsanko opened this issue May 27, 2015 · 8 comments
Closed

Click event not fired [almost always] on Android > 4.4.4 #768

tsanko opened this issue May 27, 2015 · 8 comments

Comments

@tsanko
Copy link

tsanko commented May 27, 2015

line 299 (ng-file-upload.js) : if (navigator.userAgent.toLowerCase().match(/android/)) {
....
File select dialog does not appear. (or appear once in a blue moon / cannot find any pattern)
After removing the Android specific code - everything behaves as expected.
Tested with: S4 (4.4.4) Native Browser, S5(5.0) Chrome and Native Browser, MotoX (5.0) Chrome,
Chrome @ MAC w/ device mode for Nexus 5
...
Test page does not suffer this issue (simple layout and no other components? :) )

@danialfarid
Copy link
Owner

"Test page does not suffer this issue (simple layout and no other components?"
What test page?

@tsanko
Copy link
Author

tsanko commented May 28, 2015

Project’s test/demo page. (https://angular-file-upload.appspot.com/ https://angular-file-upload.appspot.com/)
… just tried JSFiddle sample page (http://jsfiddle.net/3t50b3fw/ http://jsfiddle.net/3t50b3fw/) and don’t see any problems.

The code I mentioned does not seem to be needed for the later Android (cannot check versions earlier than 4.4.4). Maybe the check should be more granular than the very broad check for ‘android’?

On May 27, 2015, at 9:57 PM, Danial Farid notifications@github.com wrote:

"Test page does not suffer this issue (simple layout and no other components?"
What test page?


Reply to this email directly or view it on GitHub #768 (comment).

@Johnnyrook777
Copy link

I was also experiencing the same issue in our app. Removing the android specific resolution resolved it on my Android 5 device using chrome.

@tsanko
Copy link
Author

tsanko commented Jun 3, 2015

@Johnnyrook777: This is the original issue #647. Unfortunately I have no device with Android 4.2 to test browser's User-Agent string.

@danialfarid
Copy link
Owner

Gonna be fixed in the next version

@zk33
Copy link

zk33 commented Jun 4, 2015

こここきなこく

2015年6月4日木曜日、Danial Faridnotifications@github.comさんは書きました:

Gonna be fixed in the next version


Reply to this email directly or view it on GitHub
#768 (comment)
.

山崎 貴明
ymzktkak@gmail.com
080-6530-9057

danialfarid pushed a commit that referenced this issue Jun 4, 2015
@danialfarid
Copy link
Owner

Fixed in version 5.0.0

@Johnnyrook777
Copy link

Thanks danialfarid :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants