Allow frame ancestors #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a option to provide a list of CSP frame-ancestors. By default we do not allow any in order to prevent click jacking.
Adds an option to provide a list of CSP frame-ancestors. By default we do not allow any in order to prevent click jacking.
Passing run #4843 ↗︎
Details:
Review all test suite changes for PR #966 ↗︎ |
|||||||||||||||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the user to provide a
frameAncestorsoption to the engine, which follows the Content Security Policy format. An equivalent environment variable has also been created.Examples
Only allow us to put our pages in frames:
FRAME_ANCESTORS="'self'"Note: Pay attention to the single quotes!
Also allow example.com and its subdomains:
FRAME_ANCESTORS="'self',*example.com"Allow all frames (not advised):
FRAME_ANCESTORS="*"To disallow frames (default):
FRAME_ANCESTORS="'none'"We disallow frames by default in order to prevent click jacking.
Partially addresses: #950