Porting the Windows conpty part [help needed] #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to port the conpty functionality to Rust as well. I have managed to get it more or less right, but I'm a bit stuck due to my being unfamiliar with Windows API etc.
Currently, I can run a subprocess and get its output, e.g.
And I even get the callback when the process exits. But Node.js does not exit after cleanup... so there must be some resource still hanging there. Can you try this and perhaps help my find what it is?
BTW the code is messy and needs cleanup, of course. But I've got to solve this issue, otherwise this branch is just borked.