Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Buxfer API integration "storage" following the existing design pattern and style #267

Merged
merged 8 commits into from
Apr 30, 2024
Merged

Added Buxfer API integration "storage" following the existing design pattern and style #267

merged 8 commits into from
Apr 30, 2024

Conversation

nisan-tagar
Copy link
Contributor

  • Added Buxfer API integration
  • Updated README
  • Tested on local machine
  • Tests pass
  • Linter pass

@daniel-hauser
Copy link
Owner

Thanks @nissant for this change!
Can you go over my changes in the PR and ack you are ok with them?

@nisan-tagar
Copy link
Contributor Author

Thanks for those additions @daniel-hauser!
Following some tests on my accounts I will push an additional change to buxfer-ts-client package and up the minor package version here.
Will ping here once it's ready to merge.

@nisan-tagar
Copy link
Contributor Author

@daniel-hauser - Done. Please review and approve.

@nisan-tagar @daniel-hauser
Update src/storage/buxfer.ts
91136f0 
Co-authored-by: Daniel Hauser <36034483+daniel-hauser@users.noreply.github.com>
@daniel-hauser daniel-hauser merged commit 7e4f0ae into daniel-hauser:main Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-hauser daniel-hauser daniel-hauser left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisan-tagar @daniel-hauser