Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Altered CMakeLists.txt specifically for Mac OS Sierra 10.12.6 #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kkuivenhoven
Copy link

Hi Daniel,

I made PR as suggested. The CMakeLists.txt no longer has the static portion. I followed the install instructions - it installs just fine with the exception of a few Warnings. I have provided a screen shot to show the warnings.
Screen Shot 2021-03-25 at 6 25 45 PM

Copy link
Owner

@daniel-shimon daniel-shimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! We still want to compile statically on other platforms, so please apply this change :)

CMakeLists.txt Outdated
@@ -2,7 +2,7 @@ cmake_minimum_required(VERSION 3.5)
project(rpp)

set(CMAKE_CXX_STANDARD 17)
set(CMAKE_EXE_LINKER_FLAGS "-static")
set(CMAKE_EXE_LINKER_FLAGS)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(NOT APPLE)
    set(CMAKE_EXE_LINKER_FLAGS "-static")
endif()

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I see. Thanks!

@kkuivenhoven
Copy link
Author

kkuivenhoven commented May 31, 2021

Hey Daniel,

Messing around in Vim today with rpp. What is the ideal text editor to work with rpp?

For example, I follow the "Hello World" example and this is what appears in Vim:
פלוט 'שלום עולם'

When ./rpp testHello.rpp is ran, I get the following result:
םלוע

@daniel-shimon
Copy link
Owner

Hey, from my checks the only usable code editor for rpp is notepad++, which you can flip so it will be right-to-left

BTW, do you want to fix this PR so I'll merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants