Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use application context instead of context to avoid leaking memory #75

Merged

Conversation

code-schreiber
Copy link
Contributor

@code-schreiber code-schreiber commented Feb 13, 2018

To avoid the activity leaking it is enough to pass the application context and not the activity directly to ConvenienceBuilder.

Fixes issue #74

@daniel-stoneuk
Copy link
Owner

Thanks! I'll get round to merging this in a couple days.

@daniel-stoneuk daniel-stoneuk merged commit 7c019e1 into daniel-stoneuk:master Feb 20, 2018
@code-schreiber code-schreiber deleted the bug/memory_leak branch February 23, 2018 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants