Soften ecto dependency version #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielberkompas Would it be possible to get this merged in or resolved. I cannot even use the package with a new elixir project right now. |
|
@danielberkompas It would be nice, especially as v1.0 was just released, if this were incorporated. We have already adopted Ecto 3.1, and I’m having to maintain a separate fork of cloak_ecto for the moment because this would force a rollback. |
|
@halostatue @ryanpager @yogodoshi I just released cloak_ecto 1.0.1 with this fix. Thanks for your patience on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
I'm really new to the Elixir world and I also didn't find a "how to contribute" guide so please let me know if I did something wrong or need to change anything.
Context
I was using
cloak_ectoin my project but when I went to add Oban I got a dependency conflict. The easiest way to solve it seemed to be updating (or softening) the dependency requirement forectoin your package so here I am 😄What I did
I simply updated
ectoto the newest version (had to updatetelemetryas well), ran the specs, and they all passed ✅Also checked and Ecto 3.1 changelog doesn't show any dangerous change.